[8.x] Eager loading MorphTo relationship does not honor each models $keyType #34531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimpeters
changed the title
|
Is this fixing this issue or a separate issue: #34331 |
|
This is fixing an issue I have with MySQL ignoring index usage when bound parameters are passed as ints when they are numeric due to PHP array behavior of not letting strings that are valid ints be array keys as strings. I do not have access to SQL Server but after reading his issue I believe this would solve it as well. He is welcome to test this on his code base first as it is a simple change. I'm sorry I did not open an issue first. Would you like me to or we can use that issue as it's the same answer I believe. |
divine
added a commit
to mongodb/laravel-mongodb
that referenced
this pull request
Sep 30, 2020
Breaking change in minor release laravel/framework#34531
softdevee
added a commit
to softdevee/laravel-mongodb
that referenced
this pull request
Sep 5, 2022
Breaking change in minor release laravel/framework#34531
lisadeloach63
added a commit
to lisadeloach63/mongodb-laravel
that referenced
this pull request
Oct 7, 2022
Breaking change in minor release laravel/framework#34531
PermitinYury
pushed a commit
to PermitinYury/laravel-mongodb
that referenced
this pull request
Feb 17, 2023
Breaking change in minor release laravel/framework#34531
KarenEtheridg
added a commit
to KarenEtheridg/laravel-mongodb
that referenced
this pull request
Feb 17, 2023
Breaking change in minor release laravel/framework#34531
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Breaking change in minor release laravel/framework#34531
CDouglas1029
added a commit
to CDouglas1029/laravel_MongoDB
that referenced
this pull request
Nov 15, 2024
Breaking change in minor release laravel/framework#34531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eager loading a morphTo relationship that could contain models using a $keyType of 'string' each query that is built is not making sure the bound parameter is cast to string due to the dictionary being built using each model's ID as an array key.
Table A has morphTo "owner" relationship.
Table B is a related model that has a $keyType of string. Even though some of its values can be "numeric" at times.
Entries in table A for B include id values of [1,2,3]
When building the whereIn query for the database if you are not casting to a string MySQL will not use the index for that query when the column type is a char requiring a full table scan of Table B.
I really want to write tests for this but am not smart enough figure out a refactor that would give me the raw query before it's executed in
getResultsByType($type)or even mock the query builder to catch the whereIn() call and examine the parameters passed in.Thanks for your consideration.